Consequently ignore empty MQTT state payloads and set state to unknown on "None" payload#117813
Merged
Conversation
Contributor
|
Hey there @emontnemery, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
8 tasks
bdraco
reviewed
May 20, 2024
jbouwh
commented
May 21, 2024
bdraco
approved these changes
May 22, 2024
Contributor
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
bdraco
approved these changes
May 24, 2024
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
The behavior on processing empty and
"None"state payloads for MQTT entities has been made more predictable foralarm_control_panel,climate,cover,device_tracker,lock,select,valveandwater_heateritems,unknown.Previously a "None" state could be considered invalid or was just ignored.
Proposed change
See also breaking change section. The handling of empty payloads and payloads rendering to "None" are handled more consequently now.
Type of change
Additional information
Nonevalues home-assistant.io#32864Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: